On Wed, 23 Nov 2022 01:56:30 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed class header comment
>
> test/jdk/sun/java2d/marlin/HugePolygonClipTest.java line 68:
>
>> 66: System.out.println("HugePolygonClipTest: size = " + SCENE_WIDTH
>> + " x " + SCENE_HEIGHT);
>> 67:
>> 68: final BufferedImage image = new BufferedImage(SCENE_WIDTH,
>> SCENE_HEIGHT, BufferedImage.TYPE_INT_ARGB);
>
> It looks fine. One additional question did we have any tests to validate how
> the "custom images" will work? For example the image similar to this
> [one](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/image/BufferedImage.java#L383)
> but using a different order of offsets, like: int[] bOffs = {1, 0, 2, 3};
> For some other bug I have found that some our code does not expect
> "non-default" layouts.
Thanks.
In this particular test I selected ARGB as a well-known format so it does not
work with non-standard ARGB channels. I could have used getRed(), getGreen()
values to use standard API to get each components.
-------------
PR: https://git.openjdk.org/jdk/pull/11225
