On Mon, 5 Dec 2022 19:01:26 GMT, Alexey Ivanov <[email protected]> wrote:
> I think there's room for improvement. However, this is an internal-only class.
This is what I have in mind. The list of callbacks is inconsistent in how the
method and conditions when it's called are listed. One of the list items has no
ending punctuation. Some portions of text should use `<code>` or `{@code}`, or
even [`<samp>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/samp).
I think `<p>` should be added before this sentence, _“If an error results in
parsing, a RuntimeException will be thrown.”_ The sentence itself requires
re-writing: “If parsing results in an error…”
Both `RuntimeException` and `toLowerCase` below should be in `{@code}`.
The usage of `<code>` could be updated to `{@code}` which is the recommended
way.
What do you think?
-------------
PR: https://git.openjdk.org/jdk/pull/10975
