On Tue, 13 Dec 2022 16:41:42 GMT, Naveen Narayanan <d...@openjdk.org> wrote:
>> This testcase will
>> 1) Verify setAccelerator method of JMenuitem.
>> 2) Check that the selection of a menu item in the menu bar will generate
>> action by a key combination of META+M.
>>
>> Testing:
>> Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and
>> got all pass.
>
> Naveen Narayanan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8296275: Review comments fixed.
test/jdk/javax/swing/JMenuItem/JMenuItemSetAcceleratorTest.java line 61:
> 59: JMenuBar bar = new JMenuBar();
> 60: JMenu menu = new JMenu("File Menu");
> 61: JMenuItem menuItem = new JMenuItem("File");
Suggestion:
JMenu menu = new JMenu("File");
JMenuItem menuItem = new JMenuItem("Menu Item");
These used to be _File_ → _Menu Item_. I don't understand why you changed it.
-------------
PR: https://git.openjdk.org/jdk/pull/11035
