On Wed, 14 Dec 2022 15:53:52 GMT, Alexey Ivanov <[email protected]> wrote:
>>> > @aivanov-jdk I just run some test samples by making the test as headful >>> > instead as headless as @prsadhuk suggested. I found out that making it as >>> > headful works just fine and no NPE occurred (Headless always showed >>> > issue, 8/200 test). And debugging to the root cause of Image not loading >>> > is also quite difficult. I guess it's better to modify the test as >>> > headful since the reliability of the test is better in it? >>> >>> Let's go for it. A headless system could lack something that the test uses >>> even though it doesn't show the UI. >>> >>> If _headful_ systems never reproduce the problem, then it's _the fix_. >> >> So far, from the analysis it is found that the backup mechanism to get >> default Icon is failing when icon extraction fails. Not able to get the >> trigger point for the failure since it is unpredictable. Failure rate also >> seems to be dependent on system, last week used to get consistent failures >> for every test run, this week the issue is not much. So I guess making the >> test headful is better option now. > >> So far, from the analysis it is found that the backup mechanism to get >> default Icon is failing when icon extraction fails. > > These are the new details which you've never mentioned before. > > The icon extraction of a folder (presumably _Downloads_ folder) fails. The > fallback is to extract the default icon for a folder, which also fails. > > Do I understand it correctly? @aivanov-jdk I have updated the PR with the above fix, can you please review and let me know if it's Ok. ------------- PR: https://git.openjdk.org/jdk/pull/11104
