On Fri, 23 Dec 2022 06:33:25 GMT, Toshio Nakamura <[email protected]> wrote:
>> In 'Java_sun_font_FreetypeFontScaler_createScalerContextNative', >> 'context->transform.xx' and '.yy' values are sometimes 65535 instead of >> 65536. There are unintentional double and float conversions. It may be no >> real harm, but I'd like to fix it. >> >> Problem case: >> context->transform.xx=**65535** yx=0 xy=0 yy=**65535** ptsz=46.590909 >> dmat[0]=46.590909 (float)dmat[0]=46.59090**8** >> >> Normal case: >> context->transform.xx=65536 yx=0 xy=0 yy=65536 ptsz=18.000000 >> dmat[0]=18.000000 (float)dmat[0]=18.000000 >> >> Test: jdk_desktop on Linux x86_64 had no regression issues. > > Toshio Nakamura has updated the pull request incrementally with one > additional commit since the last revision: > > Adding a testcase This seems reasonable. My only concern is that you make sure this test passes on all platforms. ------------- Marked as reviewed by prr (Reviewer). PR: https://git.openjdk.org/jdk/pull/11763
