On Mon, 9 Jan 2023 18:49:23 GMT, Alexey Ivanov <[email protected]> wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
>> line 413:
>>
>>> 411: helpButtonText =
>>> UIManager.getString("FileChooser.helpButtonText",l);
>>> 412: directoryOpenButtonText =
>>> UIManager.getString("FileChooser.directoryOpenButtonText",l);
>>> 413: customApproveButtonText =
>>> UIManager.getString("FileChooser.customApproveButtonText", l);
>>
>> Not sure if it needs to be addressed throughout the file, but for the "L"
>> var at the end of each getString(), sometimes there's a space after the
>> comma and sometimes there's none. Maybe it's better to follow the same
>> convention throughout the file. Maybe it's better to just copy the lines
>> above the one's you added to match the code block only.
>
> Follow the style in the surrounding code so that newly added lines aren't out
> of place.
>
> For new isolated code, follow the common Java code style where spaces are
> added.
Yeah, updated.
-------------
PR: https://git.openjdk.org/jdk/pull/11901
