On Wed, 11 Jan 2023 06:14:41 GMT, Manukumar V S <[email protected]> wrote:

>> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS 
>> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as 
>> adding some stability improvements fixes the issue. It intermittently fails 
>> in CI causing some noise. This test was already problem listed in windows 
>> due to an umbrella bug JDK-8238720. This fix doesn't cover the Windows 
>> issue, so the problem listing in windows will remain same.
>> 
>> Fix:
>> Some stability improvements have been done and the test has been run 100 
>> times per platform in mach5 and got full PASS.
>> Also updated the screen capture code, made frame undecorated, added some 
>> prints for better debugging.
>
> Manukumar V S has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review comments fixed: Refactoring, formatting corrections, 
> frame.setVisible(true) position changed

Looks good. My main concern was the really long delay from waitForIdle. Glad a 
bug was raised for that and all of the minor issues were addressed.

-------------

Marked as reviewed by dnguyen (Author).

PR: https://git.openjdk.org/jdk/pull/10655

Reply via email to