On Wed, 18 Jan 2023 10:18:05 GMT, Tejesh R <[email protected]> wrote: > > > The test fails for me on macOS: > > > ``` > > > Caused by: java.lang.RuntimeException: Approve button tooptip is null in > > > FileChooser! > > > at CustomApproveButtonTest.<init>(CustomApproveButtonTest.java:78) > > > at CustomApproveButtonTest$1.run(CustomApproveButtonTest.java:48) > > > ``` > > > > > > I merged master into your PR branch to get the fix for > > > [JDK-8300084](https://bugs.openjdk.org/browse/JDK-8300084) and re-built > > > JDK before running the test. > > > > In your local setup?
Yes, in my local setup. I'm pretty sure it'll fail on mach5 too. > > The fallback tooltip for approve button is null for aqua, we have to skip > > checking tooltip for aqua? Should it rather be set to a non-null value? Personally, I think the tooltip for the Approve button isn't needed as its purpose is obvious. However, the tooltip is added in all the L&F, so in custom case there should also be the tooltip. ------------- PR: https://git.openjdk.org/jdk/pull/11901
