The fixed height causes the titled border insets to reserve a majority of the 
height available for the component. This fixed height is meant for the default 
AquaComboBox usage, so the old default height is more applicable when a border, 
such as TitledBorder, is set on an Aqua Editable ComboBox.

A conditional to check for a border is added since this is the default for an 
AquaComboBox using AquaBorder in AquaComboBoxUI's rectangleForCurrentValue() 
step. A check for any border rather than an instance of a TitledBorder is used 
because this issue causes changes in other borders as well (I found it for 
LineBorder for example). 

The editable JComboBox is visible with a LineBorder, but the coordinates of the 
comboBox are aligned with the top of the arrowButton instead of the bottom 
(which was the case before the previous fix). So, the method now defaults to 
the behavior before the fix for any editable comboBox pre-fix if a different 
border is set.

-------------

Commit messages:
 - Add conditional to not fix height when a border is added

Changes: https://git.openjdk.org/jdk/pull/12087/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12087&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8300269
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/12087.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12087/head:pull/12087

PR: https://git.openjdk.org/jdk/pull/12087

Reply via email to