Re: RFR: 8300549: JFileChooser Approve button tooltip is null in Aqua L&F in CUSTOM_DIALOG mode

[Alexey Ivanov]

On Wed, 25 Jan 2023 14:24:41 GMT, Tejesh R <t...@openjdk.org> wrote:

> _JFilechooser_ returns _null_ for Approve button tool tip in `CUSTOM_DIALOG` 
> mode (`getToolTipText()`). The fallback text has been set to "Choose" text. 
> Observation found in validating the test of PR - #11901.

Changes requested by aivanov (Reviewer).

src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java line 329:

> 327:         newFolderButtonText = 
> getString("FileChooser.newFolderButtonText", "New");
> 328:         newFolderTitleText = getString("FileChooser.newFolderTitleText", 
> "New Folder");
> 329:         chooseButtonToolTipText = 
> getString("FileChooser.chooseButtonToolTipText", "Choose");

I suggest having `chooseButtonText` and `chooseButtonToolTipText` next to each 
other.

The tooltip should be `"Choose selected file"` to be consistent with tooltips 
for Open and Save buttons.

I also suggest adding `FileChooser.chooseButtonToolTipText` property into 
`aqua.properties` so that it can be properly localised.

src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java line 2059:

> 2057:         // No fallback
> 2058:         String getApproveButtonToolTipText(final JFileChooser fc) {
> 2059:             return 
> getApproveButtonToolTipText(fc,chooseButtonToolTipText);

Suggestion:

            return getApproveButtonToolTipText(fc, chooseButtonToolTipText);

There was a space after the comma as it should be, let's preserve it there.

-------------

PR: https://git.openjdk.org/jdk/pull/12198