On Tue, 24 Jan 2023 23:23:32 GMT, Alisen Chung <ach...@openjdk.org> wrote:

>> Fixed test bug where mouse location was being calculated before robot 
>> mouseMove operation was complete
>
> Alisen Chung has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains three additional 
> commits since the last revision:
> 
>  - re-test
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 
> 8292588/MultiScreenLocationTest
>  - added robot wait to prevent mouse position from being calculated before 
> robot finishes mouseMove

The suggested change does fix the mouse pointer issue.

However, the test still fails for me:

Exception in thread "main" java.lang.RuntimeException: Robot.getPixelColor test 
failed on Screen #1!
        at MultiScreenLocationTest.main(MultiScreenLocationTest.java:98)


Is it possible to add diagnostic information?

If `moveMove` fails, one may want to see what the coordinates are, what the 
expected coordinates are and what the bounds of the current screen are.

If `getPixelColor` fails, what is the color of the pixel and what is the 
expected color?

These changes will be helpful for you while you debugging and updating the test 
as well as for anyone who has to deal with the test later.

-------------

Changes requested by aivanov (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10363

Reply via email to