On Thu, 19 Jan 2023 01:12:29 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

> The fixed height causes the titled border insets to reserve a majority of the 
> height available for the component. This fixed height is meant for the 
> default AquaComboBox usage, so the old default height is more applicable when 
> a border, such as TitledBorder, is set on an Aqua Editable ComboBox.
> 
> A conditional to check for a border is added since this is the default for an 
> AquaComboBox using AquaBorder in AquaComboBoxUI's rectangleForCurrentValue() 
> step. A check for any border rather than an instance of a TitledBorder is 
> used because this issue causes changes in other borders as well (I found it 
> for LineBorder for example). 
> 
> The editable JComboBox is visible with a LineBorder, but the coordinates of 
> the comboBox are aligned with the top of the arrowButton instead of the 
> bottom (which was the case before the previous fix). So, the method now 
> defaults to the behavior before the fix for any editable comboBox pre-fix if 
> a different border is set.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/12087

Reply via email to