On Wed, 25 Jan 2023 13:22:31 GMT, Nikita Gubarkov <[email protected]> wrote:
>> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bilinear-mipmap style algorithms depending on the text antialiasing hint >> - Storing BGRA glyphs in glyph cache & rendering them as plain images, as >> currently used XRender text drawing functions doesn't support colored glyphs >> - Small fixes in related code like null-checks which could cause NPE & >> comment typos > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > Skip tests if required font is absent I think I already raised this, but tests failing because Noto Color Emoji isn't installed is going to be a problem. It *largely* arises because these tests are headless .. (don't have @key headful) which in turn means that they are likely to be run on systems which aren't configured with any X11 libraries or fonts. Making them headful would be better since it is more reasonable to require that someone add a few more fonts to a system that has an Xserver than to one that isn't used for that at all. ------------- PR: https://git.openjdk.org/jdk/pull/4798
