On Thu, 26 Jan 2023 20:21:24 GMT, Phil Race <[email protected]> wrote:
>> SynthLookAndFeel.load(URL) is problematic because applications need to trust
>> the URL.
>> As documented in the bug report there are alternative mechanisms and JDK
>> itself has not used this for the two Synth based L&Fs : Nimbus and GTK.
>> So deprecating - for removal - and adding warnings now in the docs is
>> appropriate.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8300891
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
line 622:
> 620: * delivered with a {@code LookAndFeel} or application, and so have
> an
> 621: * equal level of trust with application code, using it to load from
> 622: * from remote resources, particularly any which may have a lower
> level of
Suggestion:
* equal level of trust with application code, using it to load from
* remote resources, particularly any which may have a lower level of
The word _“from”_ is repeated, thank to IDEA for catching it.
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
line 627:
> 625: * using a resource co-located with the application or by
> 626: * providing a {@code SynthStyleFactory} are preferred.
> 627: * Consequently this method is deprecated and will be removed in a
> future release.
Suggestion:
* Consequently, this method is deprecated and will be removed in a future
release.
Shall the comma be added?
-------------
PR: https://git.openjdk.org/jdk/pull/12175
