On Mon, 6 Feb 2023 01:06:32 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> C4819 warnings were reported when I tried to build JDK on Windows with >> VS2022. >> This PR contains changes both HotSpot and client libraries. Let me know if >> they should be separated. >> >> * HotSpot >> * stubGenerator_x86_64_poly.cpp >> * elfFile.hpp >> * libfontmanager >> * hb.hh >> * libfreetype >> * afblue.c >> >> I added C4819 to `DISABLED_WARNINGS_microsoft` for libfontmanager and for >> libfreetype because they are 3rd-party libraries. > > Sorry Yasumasa, but I'd much prefer to see this split into three sub-tasks > (or issues) just so we can keep the issues more clearly separated. > > IIUC for stubGenerator_x86_64_poly.cpp we have a multiplication symbol > instead of an ascii 'x' (likely pasted from a word processing document). > > For elfFile.hpp there are smart-quotes instead of ascii " > > Thanks. @dholmes-ora I splitted this in three sub tasks as #12435, #12436, #12437. I hope they are reviewed and merged. So I close this PR (but I do not close this issue on JBS until all subtasks are resolved). ------------- PR: https://git.openjdk.org/jdk/pull/12427
