On Tue, 7 Feb 2023 21:57:16 GMT, Harshitha Onkar <[email protected]> wrote:

>> FrameBorder and DialogBorder had border scaling issues similar to 
>> JInternalFrame. This fix addresses it by creating `AbstractMetalBorder` 
>> class within MetalBorder, that contains the common steps required for 
>> painting border for `FrameBorder`, `DialogBorder` and `InternalFrameBorder`. 
>> 
>> All 3 cases - JFrame, JDialog and JInternalFrame are combined into a single 
>> test case - `ScaledMetalBorderTest` and hence the older 
>> `InternalFrameBorderTest` which is no longer required, is deleted.
>
> Harshitha Onkar has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 12 additional 
> commits since the last revision:
> 
>  - minor review changes
>  - Merge branch 'master' into MetalBorderRefactor_8294484
>  - review changes: AbstractMetalWindowBorder, strokeWidth rename
>  - Merge branch 'master' into MetalBorderRefactor_8294484
>  - minor change
>  - removed unused import
>  - added updateColor(), isActive() to MetalBorder
>  - test summary changes
>  - deleted InternalFrameBorderTest
>  - moved corner var to AbstractMetalBorder
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/0546dac6...e9b37edc

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12391

Reply via email to