On Fri, 10 Feb 2023 14:49:00 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 29: >> >>> 27: * before the 'doInBackground' is finished >>> 28: * @run main TestDoneBeforeDoInBackground >>> 29: */ >> >> May I ask you to move the jtreg tags to the class declaration, please? When >> the file is opened in the IDE, they're not collapsed (together with the >> license block above) and easily accessible. > > Not sure on this..it seems it is same for other tests also.. The majority of old tests have jtreg tags above imports. I find it very inconvenient. Some newer tests have the jtreg tags before the class declaration. jtreg accepts either variant. When I review code, I always ask for this change because the jtreg tags are somewhat important and having them visible is just more convenient. The `@summary` tag provides the info similar to what one expects to find in a javadoc. ------------- PR: https://git.openjdk.org/jdk/pull/11940
