On Tue, 14 Feb 2023 19:54:04 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> The icon isn't the HTML image like in the similar test >> `HtmlButtonImageTest`. This time the HTML is the text and the icon is simply >> a separate image. This is the cause of the issue. The importance will be if >> the HTML contents is actually an image or just HTML text. > > Nevermind, I see your point now that I've reread this. Checking for an icon > achieves the same effect without having to check for an img pattern as long > as one is adjusted. So, I think the icon check is more robust and cleaner. > Thanks! @DamonGuy Additionally, you might need to make sure the conditional and the fix works under different combinations especially when you have an html with `<img>` tag + icon, both added to the button. ------------- PR: https://git.openjdk.org/jdk/pull/12520
