On Thu, 16 Feb 2023 14:38:21 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> The test has become unstable recently, there were quite a few failures, on > Windows mostly. I was lucky enough to find a host where the test failed > consistently. > > I call `System.gc()` directly as suggested in comments to the bug. I used > `PhantomReference` instead of `WeakReference`. > > Now the test calls `System.gc()` in a loop and waits for the reference to be > enqueued. In majority of cases, the test exits the loop at the second attempt. Marked as reviewed by prr (Reviewer). I'm OK with the fix. If the default collector started ignoring System.gc() it would trigger lots of test failures which would make it a JDK-wide problem to discuss first. This one test doesn't make things markedly worse, so let's approve it and you can start a discussion on core-libs-dev about this and perhaps later on hotspot-gc-dev. ------------- PR: https://git.openjdk.org/jdk/pull/12594
