On Thu, 16 Feb 2023 05:03:32 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Damon Nguyen has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Remove extra bufferedImage >> - Fix crlf >> - Add automated test. Cycle thru all LAF >> - Add testing for other LAFs > > Did you try extending DLCR for `SynthComboBoxRenderer `instead of > implementing LCR interface? > https://github.com/openjdk/jdk/blob/1480d418e3b7d1f36ace24a043a273fca446eefa/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java#L502 > > just as it is done here > https://github.com/openjdk/jdk/blob/1480d418e3b7d1f36ace24a043a273fca446eefa/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthListUI.java#L211 @prsadhuk @honkar-jdk Could you take another look because of the updates? ------------- PR: https://git.openjdk.org/jdk/pull/12390
