On Thu, 16 Mar 2023 22:55:59 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> The issue is in Aqua L&F when an editable JComboBox with a border is used. >> In this case, when the comboBox is clicked for the drop-down menu to show, >> the drop-down menu appears at the wrong coordinates (blocking the text of >> the comboBox and making it unreadable). >> >> This seems to have been the case for a while and a similar issue appeared >> recently where an editable Aqua JComboBox also had wrong positioning due to >> having a border. >> >> This fix checks for a border and modifies the bounds to accommodate the >> border's size. Then the usual calculations for the comboBox popup works as >> expected. >> >> The new headful test creates an editable comboBox with a TitledBorder and >> with no border. Then, it automatically clicks the comboBox to open the >> popup, and clicks where the position of the first selectionItem should be. >> Finally, it checks if the selected item is correct. This is for all L&F's >> and the test passes on all OS's. > > Damon Nguyen has updated the pull request incrementally with two additional > commits since the last revision: > > - Add fix for non-edit with border. Change test to have 4 iterations of > ComboBoxes > - Fix non-editable position. Dispose in finally block. Add new component to > test @prsadhuk @azvegint Could you review the updates/changes? ------------- PR: https://git.openjdk.org/jdk/pull/12750
