On Fri, 17 Mar 2023 20:28:13 GMT, Justin Lu <[email protected]> wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in the
>> .properties files as UTF-8 during the conversion from .properties file to
>> .java ListResourceBundle file.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust CF test to read in with UTF-8 to fix failing test
make/jdk/src/classes/build/tools/compileproperties/CompileProperties.java line
226:
> 224: Properties p = new Properties();
> 225: try {
> 226: FileInputStream input = new FileInputStream(propertiesPath);
Should this stream be closed in a finally { } block?
-------------
PR: https://git.openjdk.org/jdk/pull/12726
