On Tue, 21 Mar 2023 03:15:08 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> This is because the test is set to test for isPopDown set to true, which >> changes the button appearance for non-editable to be a single down arrow. >> With this set to false, the button would match native. I have updated the >> test to test the native instead. Thanks. >> >> For the editable comboboxes, the only button that is supported is the up and >> down arrow one shown. So, this one cannot be changed. >> >> They now show as: >> <img width="199" alt="Screen Shot 2023-03-17 at 11 23 11 AM" >> src="https://user-images.githubusercontent.com/96267980/225987450-0ebd0c80-cbea-4601-88d8-3155616c3c0e.png";> > > The above Apple statement only talks about non-editable combobox but I guess, > we have issue, as you told, with editable combobox buttons which as per this > code relies on BUTTON_COMBO_BOX state, so I guess we should ask Apple about > BUTTON_POP_DOWN support for editable one or any other alternative via JRS > > https://github.com/openjdk/jdk/blob/c09f83ec25749af349fb5609e3641b5bb6d34072/src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java#L144-L157 Sure, I can setup a question for clarification. Looking at the original set of questions to Apple, the dropdown button symbol was included, but wasn't answered. Must have been lost in the list of questions at the time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12750#discussion_r1143716130
![https://user-images.githubusercontent.com/96267980/225987450-0ebd0c80-cbea-4601-88d8-3155616c3c0e.png"](https://user-images.githubusercontent.com/96267980/225987450-0ebd0c80-cbea-4601-88d8-3155616c3c0e.png"){kind=link}