On Mon, 20 Mar 2023 13:06:19 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
> Please review this PR which suggests to modernize the JVM arguments used to
> enable debugging in the netbeans project files for demos.
>
> The netbeans projects found in src/demo/share/nbproject currently use the
> following outdated combination of jvm arguments to set up debugging:
>
>
> <jvmarg value="-Xdebug"/>
> <jvmarg value="-Xnoagent"/>
> <jvmarg value="-Djava.compiler=none"/>
> <jvmarg value="-Xrunjdwp:transport=dt_socket,address=${jpda.address}"/>
>
>
> They should instead just do:
>
>
> <jvmarg
> value="-agentlib:jdwp=transport=dt_socket,server=n,suspend=n,address=${jpda.address}"/>
>
>
> Additionally, the source dir set up in build.properties for these projects do
> not seem to align with the source layout.
>
> `src.dir=${main.dir}/src` should instead be just `src.dir=${main.dir}/`
After thinking this through I think I would prefer to go ahead with fixing this
in this PR, then eventually we can do another PR for a deletion.
@prrace would you consider approving this PR as-is?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13101#issuecomment-1500079954
