On Fri, 7 Apr 2023 16:24:37 GMT, Harshitha Onkar <[email protected]> wrote:
>> test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java >> line 113: >> >>> 111: frame2.setBounds(120, 120, 120, 120); >>> 112: frame2.setVisible(true); >>> 113: } >> >> So are you confident the requested location will be honoured ? >> I seem to remember a test framework fix in which you had to work quite hard >> to be sure of the real location. >> And the implied "170-120=50" might be clearer if we had variables not just >> literal numbers ? > > @prrace I agree, adding PassFailJFrame's > [syncLocationToWindowManager()](https://github.com/openjdk/jdk/blob/a8871f5d26e5cb42c031c7b736ec30b1b147a2bc/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L343) > to this test will make it more robust. > I'll change the literals to variables to make the context clear. Test updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13380#discussion_r1160869231
