On Wed, 19 Apr 2023 10:38:19 GMT, Matthias Baesken <[email protected]> wrote:
> After the latest harfbuzz update, the AIX build is broken. The old clang > compiler from xlc16 does not compile harfbuzz correctly. > First issue in hb-algs.hh is that xlc16 clang still sets some GNUC-related > macros, so we do not run into the `__clang_major__ >= 8` check that should > prevent to try to compile `__builtin_mul_overflow` with ancient clang. > The other issue in `hb-subset.cc` is a bit tricky and has been observed as > well on macOS when very old clang versions were used. > > Probably we can get rid of those 2 workarounds in some months after switching > to xlc17 which includes a rather new clang version. LGTM. Thanks for fixing the AIX build! I think we will need this fix for 11u and 17u because we will probably stick with xlc 16 for these releases. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13529#pullrequestreview-1391795403
