On Wed, 19 Apr 2023 17:22:07 GMT, Phil Race <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove start comment
>> - Made test to run on all headful platforms
>
> test/jdk/java/awt/Focus/QuickTypeTest.java line 26:
>
>> 24: @test
>> 25: @bug 4423838
>> 26: @summary KEY_TYPED and KEY_PRESSED generated by the same key are
>> notified to different fi
>
> "fi" ?
> I think a previous bug tracker had a limit on the summary field and truncated
> "fields"
> and that was copied from the tracker to the test .. but really we should fix
> that.
> And I think "TextFields" is the right word.
ok
> test/jdk/java/awt/Focus/QuickTypeTest.java line 67:
>
>> 65: EventQueue.invokeAndWait(() -> {
>> 66: // Check for Win32 environment. This test is only for
>> Win32.
>> 67: Properties prop = System.getProperties();
>
> Is it really ?
Took the test as it is..maybe at the time of test being wriiten, there was some
issue with other platforms..
seems to be working on mach5 headful platforms, so remove the windows
restriction
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13527#discussion_r1172050753
PR Review Comment: https://git.openjdk.org/jdk/pull/13527#discussion_r1172051189
