On Thu, 20 Apr 2023 08:47:08 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use Set.of() to initialize IGNORABLE_INTERFACES set.
>
> src/java.desktop/share/classes/com/sun/beans/introspect/MethodInfo.java line
> 46:
>
>> 44: final class MethodInfo {
>> 45:
>> 46: static final Set<Class<?>> IGNORABLE_INTERFACES = Set.of(
>
> Hm. Why only this specific interfaces?
This a list of commonly implemented interfaces that don't need to be inspected
because they are "known empty". This list is inspired by [Spring's
ClassUtils](https://github.com/spring-projects/spring-framework/blob/ea83d66fb5ac7e8358015f6ad938607a96ae1b41/spring-core/src/main/java/org/springframework/util/ClassUtils.java#L820-L831).
Happy to add any others that deserve to be in there.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13544#discussion_r1172620583
