> **Problem:** > > On pressing the Copy button we keep waiting in AWT-EventQueue thread in > reconstruct() function as we detect that we have missing information for the > animated image since we are copying single frame at a time. > Due to this infinite wait the application freezes. > > **Proposed Fix:** > > There are conditions in the reconstruct() function that avoid entering the > wait() code if we have some error reading the image , etc. So, I added the > condition to avoid entering the wait() code if we are copying single frame at > a time. This sounded logical to me since if we have incomplete > information(single frame) about the animated image we shouldn’t keep waiting, > as it leads to infinite wait. > After this change I see the GIF image being correctly copied and animated. > > > **Testing:** > > Added a test for this (bug6176679.java) and tested locally on my Windows > machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with three additional commits since the last revision: - Update ImageRepresentation.java code cleanup - Update ImageRepresentation.java code cleanup - update fix to work for both cases where image is displayed and not displayed ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13414/files - new: https://git.openjdk.org/jdk/pull/13414/files/79874ada..74c5c675 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13414&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13414&range=09-10 Stats: 36 lines in 2 files changed: 25 ins; 5 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/13414.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13414/head:pull/13414 PR: https://git.openjdk.org/jdk/pull/13414
