On Thu, 4 May 2023 18:20:58 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java > line 365: > >> 363: >> 364: if (start >= 0 && end > start) { >> 365: List<File> listStart_OldSize = new >> Vector<>(fileCache.subList(start, oldSize)); > > Why Vector was used instead of ArrayList ? Nothing specific reason why I choose vector apart from the main object is of Vector type and since in this context (where both the objects are not shared) both Vector/Arraylist comparison remains same. Does Arraylist comparison has any advantage here? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13783#discussion_r1185710608