On Fri, 5 May 2023 09:54:36 GMT, Tejesh R <t...@openjdk.org> wrote:
> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
test/jdk/java/awt/Panel/SetForegroundTest.java line 33:
> 31: import java.awt.Color;
> 32:
> 33: import javax.swing.JWindow;
Would be nice to have an empty line here
test/jdk/java/awt/Panel/SetForegroundTest.java line 51:
> 49: } finally {
> 50: EventQueue.invokeAndWait(() -> {
> 51: if(jwindow != null) {
if( -> if (
test/jdk/java/awt/Scrollbar/PageIncrementTest.java line 39:
> 37:
> 38: public static void main(String[] args) throws Exception {
> 39: EventQueue.invokeAndWait(() -> {
Not sure why this test needs to run on EDT.
It is just a unit test and doesn't create a Window/Frame.
test/jdk/java/awt/Scrollbar/ScrollbarKeyControlTest.java line 61:
> 59: System.out.println("This test is for XAWT only.");
> 60: return;
> 61: }
This is largely pointless since you have requires os==linux.
Perhaps its from when we had MToolkit.
If you keep it, then I'd make it just check the "os.name" and not the toolkit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1186359997
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1186361163
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1186363103
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1186365441
