> Hi Reviewers, > Noticed this test case not verifying all the cases which is intended. > Modified it for improving the coverage for 3 type of popups (menu, context > menu and combobox). > > Evaluating conditions: > 1. Not enough space for showing popup downwards(default layout), it should > show upwards > 2. Window starts from negative position, Popup should show on visible area > > For achieving this following areas are modified > - Updated isPopupOnScreen by adding Additional checks (like the position of > combobox popup is always verified) > - Menu creation made as function and reused for all menu creation. > - Updated ComboPopupCheckListener class and modified its > popupMenuWillBecomeInvisible function. Made it as generic and it is capable > to evaluate any combo box's position if this class set as its listener. > - This test case is not intended for multi monitor setup so added a check for > identifying monitor, else error out. > - Updated CTRL_MASK to CTRL_DOWN_MASK for removing depreciation warnings and > removed some other warnings. > > Please review this > > Regards, > Renjith.
Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision: Updated test description, disabling all system shortcut is required to run the test case on MAC ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13578/files - new: https://git.openjdk.org/jdk/pull/13578/files/b6b521b9..a46881b2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13578&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13578&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/13578.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13578/head:pull/13578 PR: https://git.openjdk.org/jdk/pull/13578
