On Thu, 11 May 2023 08:22:10 GMT, Tejesh R <t...@openjdk.org> wrote:
>> Open source few AWT ScrollPane related tests.
>
> Tejesh R has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updated based on review comments
> - Updated based on review comments
test/jdk/java/awt/ScrollPane/ComponentScrollTest.java line 81:
> 79: EventQueue.invokeAndWait(() -> {
> 80: frame.pack();
> 81: frame.setVisible(true);
should frame setup code be moved into init()?
test/jdk/java/awt/ScrollPane/ScrollPaneLimitation.java line 94:
> 92: frame.setLocationRelativeTo(null);
> 93: frame.setVisible(true);
> 94: pane.doLayout();
frame setup moved to init() here too?
test/jdk/java/awt/ScrollPane/ScrollPaneRemoveAdd.java line 88:
> 86: pane.add(button);
> 87: buttonLoc = button.getLocationOnScreen();
> 88: buttonSize = button.getSize();
here too
test/jdk/java/awt/ScrollPane/ScrollPaneWindowsTest.java line 92:
> 90: frame.setLocationRelativeTo(null);
> 91: frame.setVisible(true);
> 92: paneInsets = sp.getInsets();
here too
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1192726569
PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1192727481
PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1192727730
PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1192727939
