On Wed, 24 May 2023 19:53:00 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>>> I looked at the JBS issue and this PR's description but when I look at the >>> changes, there are changes to tests as well, like the awt TrayIcon one. Is >>> that meant to be included? Or is that a separate change that accidentally >>> got bundled with this change to PassFailJFrame? >> >> I believe this is intended to demonstrate the usage of the screenshot >> feature. >> >> Yet it may be a hindrance for backporting… if the modified tests don't exist >> in previous versions or there are other differences… > >> Yet it may be a hindrance for backporting… if the modified tests don't exist >> in previous versions or there are other differences… > > To facilitate backporting, this PR may be broken into two PRs: the first one > which updates the API of `PassFailJFrame`, the second, dependent, PR updates > the tests. > > I faced some difficulties when I was backporting `PassFailJFrame` to 17u and > 11u because some changes to the framework were combined with tests. The > `PrintLatinCJKTest` test that is modified here isn't backported to 17u or 11u. > > I will definitely want to backport these changes to previous versions of JDK, > so I am for *splitting the PR*. Thank you, @DamonGuy, for bringing this up. @aivanov-jdk > Yet it may be a hindrance for backporting… if the modified tests don't exist > in previous versions or there are other differences… I agree, framework changes and test changes can be separated for easier back-porting. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14094#issuecomment-1562043802
