On Wed, 31 May 2023 11:34:19 GMT, Tejesh R <t...@openjdk.org> wrote:

> When a frame is dragged from one screen to another screen, the 
> `GraphicsConfigurations` may vary depending on screen/monitor. However, 
> transparency has to be maintained since it is expected as it is set. So the 
> fix addresses in maintaining the translucency capability when frame is moved 
> from one screen to another screen. For main screen, translucency is set when 
> `setBackground` is called, but for second screen the same is not taken care. 
> Hence setting of Translucency Capable `GC` is taken care when screen switch 
> happens. The fix handles only for non-opaque windows alone retaining the 
> behavior for opaque windows. 
> The fix is verified in CI for regression check, which is Green.

test/jdk/java/awt/Window/MultiscreenTransparencyTest.java line 43:

> 41:  * @bug 8006421
> 42:  * @key headful
> 43:  * @requires (os.family == "linux")

Does this have to be linux only? Can't this be a generic test?

test/jdk/java/awt/Window/MultiscreenTransparencyTest.java line 62:

> 60: 
> 61:         if (gds.length != 2)
> 62:         {

Move curly brace to the same line as if.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14246#discussion_r1214581893
PR Review Comment: https://git.openjdk.org/jdk/pull/14246#discussion_r1214580368

Reply via email to