On Fri, 2 Jun 2023 19:35:23 GMT, Harshitha Onkar <[email protected]> wrote:

>> ViewportOverlapping test was failing intermittently during CI runs on Win10 
>> and Win11. 
>> 
>> Although this intermittent issue wasn't replicable when the individual test 
>> as well as the test group was run multiple times. Hence screenshot capture 
>> has been at various points in the test to aid debugging this intermittent 
>> issue, in case it should occur again. 
>> 
>> PS: Only relevant code in OverlappingTestBase has been cleaned-up as 
>> required by this test. There are other parts of the base class that require 
>> code clean-up  which is best if taken up as a separate issue as it has 
>> common code across many AWT_Mixing tests.
>
> Harshitha Onkar has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   review fix

test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 425:

> 423:         try{
> 424:             Thread.sleep(500);
> 425:         } catch(Exception exx) {

Suggestion:

        } catch (Exception exx) {

test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 483:

> 481:         try {
> 482:             robot = new Robot();
> 483:         } catch(Exception ignored) {

Suggestion:

        } catch (Exception ignored) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14289#discussion_r1217156635
PR Review Comment: https://git.openjdk.org/jdk/pull/14289#discussion_r1217156826

Reply via email to