On Wed, 14 Jun 2023 21:15:15 GMT, Alexey Ivanov <[email protected]> wrote:

>> test/jdk/javax/swing/JFileChooser/FileChooserSizeLabelCutOffTest.java line 
>> 118:
>> 
>>> 116:     }
>>> 117: 
>>> 118:     private static JTable findTable(final Container container) {
>> 
>> This method is not called at any place, can it be removed?
>
>> This method is not called at any place, can it be removed?
> 
> This and following `find`-methods are from an automated test, they should be 
> removed unless it's possible to automate the test.
> 
> Is it possible? It could be. You have to determine the coordinates of the 
> header cell, then take a MRI screenshot, verify the 2*scale right-most pixels 
> are filled with header background color only.

Yeah, was actually trying to do that but couldn't get exact coordinates of 
header cell. Later on forgot to remove the unused methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14464#discussion_r1230405238

Reply via email to