On Tue, 20 Jun 2023 20:17:04 GMT, Phil Race <[email protected]> wrote:

> But PROBABLY most people putting a toolbar on the EAST will make it vertical 
> so I expect few apps
> to see an unwelcome change in behaviour here .. but there's always a risk of 
> that.

I am not sure on this point being "unwelcome change"....I think even if there 
is a change in behaviour, it is as per expectation as 
If a user docks a "horizontal" toolbar in EAST and then it is dragged and 
floated and then closed, I think it should be expected to dock the toolbar as 
it is ie HORIZONTAL in EAST side, that is what it was before docking. If 
orientation is changed to VERTICAL while in floating state and then closed, 
then the toolbar should be docked at EAST in VERTICAL state

As you correctly pointed out it is not correct that `"the orientation should 
change to the appropriate value, even if the orientation has been set 
explicitly"` so orientation and docking point should not be changed by the 
implementation.
Also, it was mentioned in that bug that `"The documentation should be changed 
to clarify this. "` which was not done even though the implementation was done 
so it seems prudent to rectify the implementation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14444#issuecomment-1600076628

Reply via email to