Re: RFR: 8140527: JInternalFrame has incorrect title button width [v2]

[Prasanta Sadhukhan]

On Wed, 21 Jun 2023 15:44:26 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Review comments
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java
>  line 88:
> 
>> 86:             }
>> 87:         } else {
>> 88:             buttonWidth = buttonHeight;
> 
> This means line 71 can be removed because `buttonWidth` is never read from 
> `UIManager`.

It can be removed in the strict sense but we need something to initialise it to 
so kept it as it is, as it will do no harm

> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java
>  line 89:
> 
>> 87:         } else {
>> 88:             buttonWidth = buttonHeight;
>> 89:             buttonWidth += 2;
> 
> Shouldn't the buttons be square in the classic theme?

If we make it exactly square, it results in some loss of aesthetics as can be 
seen here where icon is too close to right edge, so kept it as it is

![image](https://github.com/openjdk/jdk/assets/43534309/73a54d2d-308c-47e3-9809-420e278a9c6d)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14555#discussion_r1237952859
PR Review Comment: https://git.openjdk.org/jdk/pull/14555#discussion_r1237953531