On Thu, 29 Jun 2023 13:39:50 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comment update > > test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line > 30: > >> 28: * @build PassFailJFrame >> 29: * @requires (os.family == "mac") >> 30: * @summary Verifies if JComboBox selected itemmagnifies using > > Suggestion: > > * @summary Verifies if JComboBox selected item magnifies using Updated. > test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line > 68: > >> 66: frame.dispose(); >> 67: } >> 68: }); > > This is redundant, `PassFailJFrame` automatically handles disposing of > windows which are added using the `addTestWindow` method. Updated. > test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line > 77: > >> 75: "Mango", "Pine Apple", "Banana"}; >> 76: JComboBox<String> comboBox = new JComboBox<String>(fruits); >> 77: JPanel fruitPanel = new JPanel(new GridLayout(1,2)); > > Suggestion: > > JPanel fruitPanel = new JPanel(new GridLayout(1, 2)); Updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1247540422 PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1247540469 PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1247540502
