On Tue, 4 Jul 2023 11:46:31 GMT, Tejesh R <t...@openjdk.org> wrote:

>> Tried to check the line alignment, but couldn't do it because of anti 
>> aliasing and scaling. And before and after fix means storing the image of 
>> before fix and then comparing with after fix?
>
> Still I feel that would be blind comparison, since we won't be able to 
> exactly test the fix.

I strongly believe it should be an automated test. It may even be headless, if 
possible. There are a couple of examples which compare border rendering.

You don't need to store images, just count the number of pixels of a particular 
colour. If you detect an inconsistency, fail the test. You may need to tweak 
the width or height of columns and rows so that old method results in visible 
inconsistencies in rendering.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14766#discussion_r1251993109

Reply via email to