On Mon, 17 Jul 2023 08:24:44 GMT, Renjith Kannath Pariyangad <d...@openjdk.org>
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization library load proper GUID (same as registry).
>> 2. For Play back device always loading proper device GUID irrespective of
>> com Initialization.
>>
>> Test:
>> Since screen lock and unlock workflow required for reproducing this issue,
>> did coupe of iteration of manual testing post fix and confirmed its
>> resolving the problem.
>> To reconfirm nothing is broken, executed all audio related test cases on
>> test bench post fix and all are green.
>>
>> Please review the changes and let me know your comments if any.
>>
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Updated copyright year
src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp
line 482:
> 480: DWORD WINAPI __stdcall DS_StartBufferHelper::ThreadProc(void *param)
> 481: {
> 482: ::CoInitializeEx(NULL, COINIT_MULTITHREADED);
The documentation for the `CoInitializeEx` suggests to disable the
`COINIT_DISABLE_OLE1DDE`:
https://learn.microsoft.com/en-us/windows/win32/learnwin32/initializing-the-com-library
I think we do not need ole1 here and can disable that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1267402244
