On Fri, 21 Jul 2023 06:23:29 GMT, Damon Nguyen <[email protected]> wrote:
>> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Skip GTK L&F > > src/java.desktop/share/classes/sun/swing/FilePane.java line 1936: > >> 1934: } >> 1935: >> 1936: >> contextMenu.applyComponentOrientation(getFileChooser().getComponentOrientation()); > > I see that this bug is old. Seems like a simple way to fix this and I see > similar calls for other UI elements, like JMenu. It looks like in JMenu, it > iterates through all components and sets it orientation, but it looks like > the popup is the only problem, so looks fine. > > You still need to update the year in the header of FilePane. Yeah, `applyComponentOrientation ` iterates through all the child components and sets the orientation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14949#discussion_r1270292308
