On Wed, 2 Aug 2023 04:14:13 GMT, Tejesh R <[email protected]> wrote:

>> test/jdk/javax/swing/JTableHeader/JTableHeaderLabelRightAlignTest.java line 
>> 98:
>> 
>>> 96:     }
>>> 97: 
>>> 98:     private static void saveBufferedImage(BufferedImage image, String 
>>> fileName) {
>> 
>> `saveImage` should be enough as in #14766?
>
> I have used `saveBufferedImage` in both the test/PR, I think it should be 
> fine.

My point is that `saveImage` clearly conveys the meaning, you pass a 
`BufferedImage`, which implies you save a buffered image. Whatever, but shorter 
name is better in my opinion, and it's used in many other tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14464#discussion_r1281784313

Reply via email to