On Wed, 2 Aug 2023 09:45:34 GMT, Renjith Kannath Pariyangad <d...@openjdk.org> wrote:
>> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp >> line 262: >> >>> 260: } >>> 261: if(FAILED(::CoInitialize(NULL))) >>> 262: return false; >> >> DS_unlockCache if the CoInitialize fails? > > Thank you for pointing this, I have clubbed CoInitialize check along with > other condition. In case of failure it will return there itself. This code has the same issue: "if (!DS_lockCache() || FAILED(::CoInitialize(NULL)))" ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1282665870
