On Sun, 27 Aug 2023 21:41:43 GMT, Rajat Mahajan <rmaha...@openjdk.org> wrote:

> I have made the test changes to include radio button in menu and tested the 
> same and it works fine.

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 1:

> 1: /*

You could add [8294427](https://bugs.openjdk.org/browse/JDK-8294427) to the 
`@bug` tag because this test can be also used to verify the markers render 
correctly.

The instructions may be expanded to test the markers are still crisp after 
changing the scale in Windows settings.

test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 66:

> 64:             + "   If so, press PASS, else press FAIL.\n";
> 65: 
> 66:     public static void main(String args[]) throws Exception {

Suggestion:

    public static void main(String[] args) throws Exception {

To fix the IDEA warning.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15441#pullrequestreview-1599040802
PR Review Comment: https://git.openjdk.org/jdk/pull/15441#discussion_r1307906164
PR Review Comment: https://git.openjdk.org/jdk/pull/15441#discussion_r1307907434

Reply via email to