On Mon, 28 Aug 2023 21:24:45 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Previously, a new key combination involving the option key was added to Aqua >> LAF for JTextAreas. In doing so, some code was removed that created this >> regression. The regression caused the right option key on Mac OS to >> incorrectly show another KeyPressed event instead of a KeyReleased event >> when pressing and releasing the key. Additionally, the location of the key >> was 'standard' instead of 'right'. Adding back the key mask and its >> following code resolves the issue and doesn't cause any other CI tests to >> fail. >> >> The headful test included displays the key events as they're pressed. After >> the changes, the test correctly shows the right option key's KeyPressed and >> KeyReleased events and shows the location as 'right'. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove duplicate alt key mask. Add value to other mask. why was the keycode wrong with the previous fix? and why do we need to manually set leftAltKeyPressed = YES? should this be done in a different part of the code? ------------- PR Comment: https://git.openjdk.org/jdk/pull/15432#issuecomment-1696494494