On Wed, 30 Aug 2023 18:42:20 GMT, Phil Race <[email protected]> wrote:
>> Please double-check how the external tools like jaws/narrator will work >> after this change, will they be able to read the correct content of the menu >> item? > >> @mrserb >> >> > Please double-check how the external tools like jaws/narrator will work >> > after this change, will they be able to read the correct content of the >> > menu item? >> >> The updating of the label works correctly since the application handles the >> drawing/updating of the string as specified by the `mii.fType = >> MFT_OWNERDRAW` without requiring to set `dwTypeData`. To double-check ran >> JAWS and it works as expected & reads out the new label name when updated. > > Hmm, so where does JAWS get that info if we no longer set it ? It isn't > scraping pixels and doing OCR. > > Seems like a lot of changes here to silence a warning we don't even get. @prrace The drawing of the label is being handled by the application here [AwtMenuItem::DrawItem](https://github.com/openjdk/jdk/blob/63f561fac2eb6ec57f860af71cd6deebb9027aaf/src/java.desktop/windows/native/libawt/windows/awt_MenuItem.cpp#L485) & [AwtMenuItem::DrawSelf](https://github.com/openjdk/jdk/blob/63f561fac2eb6ec57f860af71cd6deebb9027aaf/src/java.desktop/windows/native/libawt/windows/awt_MenuItem.cpp#L302). ------------- PR Comment: https://git.openjdk.org/jdk/pull/15276#issuecomment-1701849302
