On Fri, 1 Sep 2023 12:52:43 GMT, Alexey Ivanov <[email protected]> wrote:
>> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8312165: Fix typos in java.desktop Swing >> >> apply suggestions from review > > src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 1295: > >> 1293: // ab[B. I'd actually prefer abB]. But, if I implement that >> 1294: // a delete at abBA] would result in aBA] vs a[BA which I >> 1295: // think is totally wrong. To get this right we need to know >> what > > Suggestion: > > // ab[B. I'd actually prefer abB]. But, if I implement that, > // a delete at abBA] would result in aBA] vs a[BA which, I > // think, is totally wrong. To get this right we need to know what > > Let's drop some more commas to separate the complex sentences. Especially, > the one on the first line where “that” could be interpreted as a conjunction > otherwise. > > I've been looking over all the changes, and again I struggled to parse the > comment. Thanks. Applied. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14847#discussion_r1313484963
