On Thu, 14 Sep 2023 15:27:48 GMT, Alexander Zuev <[email protected]> wrote:
>> Clean up and move to open source five tests. >> javax/swing/AncestorNotifier/4817630/bug4817630.java >> javax/swing/BoxLayout/4191948/bug4191948.java >> javax/swing/ComponentInputMap/4248723/bug4248723.java >> javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java >> javax/swing/DefaultButtonModel/4097723/bug4097723.java > > Alexander Zuev has updated the pull request incrementally with two additional > commits since the last revision: > > - Update test/jdk/javax/swing/AncestorNotifier/4817630/bug4817630.java > > Co-authored-by: Andrey Turbanov <[email protected]> > - Update > test/jdk/javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java > > Co-authored-by: Andrey Turbanov <[email protected]> LGTM. Just move the frame dispose code blocks to EDT. test/jdk/javax/swing/AncestorNotifier/4817630/bug4817630.java line 112: > 110: test.start(); > 111: } finally { > 112: test.destroy(); Either destroy() or the if statement in destroy() for disposing the frame should be on EDT test/jdk/javax/swing/BoxLayout/4191948/bug4191948.java line 76: > 74: frame.setVisible(false); > 75: frame.dispose(); > 76: } Should this if statement be run on EDT? ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/15702#pullrequestreview-1627795667 PR Review Comment: https://git.openjdk.org/jdk/pull/15702#discussion_r1326547720 PR Review Comment: https://git.openjdk.org/jdk/pull/15702#discussion_r1326547278
